Skip to content

ENABLE_VIXL_DISASSEMBLER should enable extra sources#5

Merged
Sonicadvance1 merged 1 commit intoFEX-Emu:fex8from
pmatos:UBSan-Compile
Apr 30, 2025
Merged

ENABLE_VIXL_DISASSEMBLER should enable extra sources#5
Sonicadvance1 merged 1 commit intoFEX-Emu:fex8from
pmatos:UBSan-Compile

Conversation

@pmatos
Copy link
Copy Markdown

@pmatos pmatos commented Apr 8, 2025

No description provided.

Noticed this is required when compiling with UBsan.
@pmatos
Copy link
Copy Markdown
Author

pmatos commented Apr 8, 2025

I clearly did not mean to do this - i.e. create a 123 file commit.

@pmatos pmatos changed the base branch from main to fex8 April 8, 2025 14:02
@pmatos
Copy link
Copy Markdown
Author

pmatos commented Apr 8, 2025

Ah, ok - initially I chose the wrong base.
We need to be able to add the extra sources when enabling the VIXL DISASSEMBLER but not the SIMULATOR. This doesn't fail unless compiled with ubsan support on clang19.

@pmatos
Copy link
Copy Markdown
Author

pmatos commented Apr 30, 2025

ping @Sonicadvance1

@Sonicadvance1
Copy link
Copy Markdown
Member

Still weird that the simulator is required if the disassembler is enabled, but whatever.

@Sonicadvance1 Sonicadvance1 merged commit 86b0d53 into FEX-Emu:fex8 Apr 30, 2025
@pmatos pmatos deleted the UBSan-Compile branch May 5, 2025 08:56
@crueter crueter mentioned this pull request Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants