As a note here, we can't support 16-bit addressing modes because Linux reserves the lowest 16-bits of VA space. Requires the use of segments to offset everything, which isn't setup at all.

which games out of interest?

which games out of interest?

Good question - need to rerun the last batch to tell you. I will get back to you on this.

It looks like you've run afoul of out of all the string operating instructions, stos and scas both will fault if attempting to get used with a null-selector for the ES segment register.

This patch to the ASM generation will fix it.

diff --git a/unittests/32Bit_ASM/CMakeLists.txt b/unittests/32Bit_ASM/CMakeLists.txt
index 462b319d4..187a5a675 100644
--- a/unittests/32Bit_ASM/CMakeLists.txt
+++ b/unittests/32Bit_ASM/CMakeLists.txt
@@ -30,7 +30,7 @@ foreach(ASM_SRC ${ASM_SOURCES})
   add_custom_command(OUTPUT ${TMP_FILE}
     DEPENDS "${ASM_SRC}"
     COMMAND "cp" ARGS "${ASM_SRC}" "${TMP_FILE}"
-    COMMAND "sed" ARGS "-i" "-e" "\'1s;^;BITS 32\\norg 10000h\\nmov eax, 0x17\\nmov ds, ax\\n;\'" "-e" "\'\$\$a\\ret\\n\'" "${TMP_FILE}"
+    COMMAND "sed" ARGS "-i" "-e" "\'1s;^;BITS 32\\norg 10000h\\nmov eax, 0x17\\nmov ds, ax\\nmov es, ax\\n;\'" "-e" "\'\$\$a\\ret\\n\'" "${TMP_FILE}"
     )

   set(OUTPUT_NAME "${OUTPUT_ASM_FOLDER}/${ASM_NAME}.bin")

It looks like you've run afoul of out of all the string operating instructions, stos and scas both will fault if attempting to get used with a null-selector for the ES segment register.

This patch to the ASM generation will fix it.

diff --git a/unittests/32Bit_ASM/CMakeLists.txt b/unittests/32Bit_ASM/CMakeLists.txt
index 462b319d4..187a5a675 100644
--- a/unittests/32Bit_ASM/CMakeLists.txt
+++ b/unittests/32Bit_ASM/CMakeLists.txt
@@ -30,7 +30,7 @@ foreach(ASM_SRC ${ASM_SOURCES})
   add_custom_command(OUTPUT ${TMP_FILE}
     DEPENDS "${ASM_SRC}"
     COMMAND "cp" ARGS "${ASM_SRC}" "${TMP_FILE}"
-    COMMAND "sed" ARGS "-i" "-e" "\'1s;^;BITS 32\\norg 10000h\\nmov eax, 0x17\\nmov ds, ax\\n;\'" "-e" "\'\$\$a\\ret\\n\'" "${TMP_FILE}"
+    COMMAND "sed" ARGS "-i" "-e" "\'1s;^;BITS 32\\norg 10000h\\nmov eax, 0x17\\nmov ds, ax\\nmov es, ax\\n;\'" "-e" "\'\$\$a\\ret\\n\'" "${TMP_FILE}"
     )

   set(OUTPUT_NAME "${OUTPUT_ASM_FOLDER}/${ASM_NAME}.bin")

Thanks I was adding that to the tests but clearly there it's better. Still there's still a failure I need to investigate:

host/Test_32Bit_FEX_bugs/GOT_calculation.asm

Thanks I was adding that to the tests but clearly there it's better. Still there's still a failure I need to investigate:

host/Test_32Bit_FEX_bugs/GOT_calculation.asm

oh, i see, the cmakelists patch screwed got_calculation. will fix that now.

which games out of interest?

I have seen this in more but Overcooked 2 has several:

E can't handle address size

errors.

That's just the JIT exploring garbage code, it isn't actually used.