Skip to content

f80 stack xchg optimization for fast path#5009

Merged
Sonicadvance1 merged 2 commits intoFEX-Emu:mainfrom
pmatos:feat/stack-xchange-opt
Nov 5, 2025
Merged

f80 stack xchg optimization for fast path#5009
Sonicadvance1 merged 2 commits intoFEX-Emu:mainfrom
pmatos:feat/stack-xchange-opt

Conversation

@pmatos
Copy link
Copy Markdown
Collaborator

@pmatos pmatos commented Oct 30, 2025

We were calling the generic function, making the impl. itself simpler but doing more work than needed in this particular instance.

Copy link
Copy Markdown
Collaborator

@bylaws bylaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See instcountci ci, this regresses it

@pmatos
Copy link
Copy Markdown
Collaborator Author

pmatos commented Nov 5, 2025

See instcountci ci, this regresses it

huh, thanks for pointing this out. weird. I was pretty sure it was improving it when I started splitting the patches.

@pmatos pmatos force-pushed the feat/stack-xchange-opt branch from 12c3cdf to e3de620 Compare November 5, 2025 10:20
@pmatos
Copy link
Copy Markdown
Collaborator Author

pmatos commented Nov 5, 2025

See instcountci ci, this regresses it

Yeah, my mistake sorting out the split. It's updated now.

@pmatos pmatos requested a review from bylaws November 5, 2025 10:20
@Sonicadvance1 Sonicadvance1 merged commit 93e58bc into FEX-Emu:main Nov 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants