Skip to content

Fix IEEE 754 unordered comparison detection in x87 floating-point operations#4811

Merged
Sonicadvance1 merged 3 commits intoFEX-Emu:mainfrom
pmatos:fix/SPEC_GCC-C-execute-ieee-fp-cmp-8l
Sep 1, 2025
Merged

Fix IEEE 754 unordered comparison detection in x87 floating-point operations#4811
Sonicadvance1 merged 3 commits intoFEX-Emu:mainfrom
pmatos:fix/SPEC_GCC-C-execute-ieee-fp-cmp-8l

Conversation

@pmatos
Copy link
Copy Markdown
Collaborator

@pmatos pmatos commented Sep 1, 2025

Fix SoftFloat IsNan - custom detection matches IEEE754 semantics.
Sets Invalid Operation flags properly for NaN comparisons.

Fixes: GCC-C-execute-ieee-fp-cmp-8l test
__builtin_isunordered() now returns correct values for both NaN and normal operands

@pmatos pmatos changed the title Fix/spec gcc c execute ieee fp cmp 8l Fix IEEE 754 unordered comparison detection in x87 floating-point operations Sep 1, 2025
…rations

Fix SoftFloat IsNan - custom detection matches IEEE754 semantics.
Sets Invalid Operation flags properly for NaN comparisons.

Fixes: GCC-C-execute-ieee-fp-cmp-8l test
__builtin_isunordered() now returns correct values for both NaN and normal operands
@pmatos pmatos force-pushed the fix/SPEC_GCC-C-execute-ieee-fp-cmp-8l branch from 0644678 to 7773f9f Compare September 1, 2025 16:26
@pmatos pmatos force-pushed the fix/SPEC_GCC-C-execute-ieee-fp-cmp-8l branch from 7773f9f to 0882b0d Compare September 1, 2025 19:42
Copy link
Copy Markdown
Member

@Sonicadvance1 Sonicadvance1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy fancy

@Sonicadvance1 Sonicadvance1 merged commit 4a71edf into FEX-Emu:main Sep 1, 2025
14 of 15 checks passed
@pmatos pmatos deleted the fix/SPEC_GCC-C-execute-ieee-fp-cmp-8l branch September 2, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants