Skip to content

Set clang-format-19 as the version git-clang-format should run in wor…#4666

Merged
Sonicadvance1 merged 1 commit intoFEX-Emu:mainfrom
pmatos:fix/git-clang-format-19
Jul 14, 2025
Merged

Set clang-format-19 as the version git-clang-format should run in wor…#4666
Sonicadvance1 merged 1 commit intoFEX-Emu:mainfrom
pmatos:fix/git-clang-format-19

Conversation

@pmatos
Copy link
Copy Markdown
Collaborator

@pmatos pmatos commented Jul 14, 2025

…kflow

@pmatos
Copy link
Copy Markdown
Collaborator Author

pmatos commented Jul 14, 2025

Alternatively we would need to specify --binary when calling git-clang-format.

Unfortunately git-clang-format-19 will not call clang-format-19 but the system clang-format
so we need to hardcode it here.
@pmatos pmatos force-pushed the fix/git-clang-format-19 branch from 7f6dca8 to b5f8dd9 Compare July 14, 2025 16:37
@pmatos
Copy link
Copy Markdown
Collaborator Author

pmatos commented Jul 14, 2025

I pushed the alternative of setting the --binary argument instead. I think it's better because it will work for us locally as well.

@Sonicadvance1 Sonicadvance1 merged commit 70ce323 into FEX-Emu:main Jul 14, 2025
12 checks passed
@pmatos pmatos deleted the fix/git-clang-format-19 branch July 15, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants