Whole-tree reformat with clang-format-19#4661
Conversation
|
@Sonicadvance1 here it is. |
|
The changes to lambda indentation are unfortunate - does |
CodeEmitter/CodeEmitter/ALUOps.inl
Outdated
| [[maybe_unused]] | ||
| const auto IsImm = IsImmLogical(Imm, RegSizeInBits(s), &n, &imms, &immr); |
There was a problem hiding this comment.
The line breaks here add a lot of noise, so I'm tempted to just switch to BreakAfterAttributes: Leave at the expense of not enforcing breaks in function declarations anymore.
What do you think?
There was a problem hiding this comment.
Yeah, I will try to see what works to avoid that. Another thing I just noticed is that we are reformatting stuff in External/. Does it make sense? My gut feeling is that we shouldn't be doing it.
There was a problem hiding this comment.
I just checked and we didn't do it for the initial reformatting so lets skip it again, unless you disagree.
There was a problem hiding this comment.
Another thing I just noticed is that we are reformatting stuff in External/.
I just checked and we didn't do it for the initial reformatting so lets skip it again, unless you disagree.
Sounds good.
Been trying to undo the issue with attribute being broken but playing around with the penalties means making something else worse. Do you have any further comments or suggestions?
Does BreakAfterAttributes: Leave have undesired side-effects too or are you just experimenting to see if something better can be found?
pmatos
force-pushed
the
feature/reformat-clang-format-19
branch
from
d736e8f to
c9befa5
Compare
|
Been trying to undo the issue with attribute being broken but playing around with the penalties means making something else worse. Do you have any further comments or suggestions? |
|
From a quick scan, nothing here seems terrible. Fine with me. |
pmatos
force-pushed
the
feature/reformat-clang-format-19
branch
from
c9befa5 to
a117f05
Compare
OK - rebased. Once it's ok just merge, otherwise I will have to keep updating the sha in |
pmatos
force-pushed
the
feature/reformat-clang-format-19
branch
from
a117f05 to
1d73276
Compare
Argh, I reformatted and forgot those because I resetted the changed .clang-format. Sorry. Added the |
No worries! Going from a 1250 loc diff to 250 sounds like a solid win to me. Not sure why clang 16 missed so many lambda indentation cases before, but personally I like Thanks for taking care of this; looking forward to finally re-enabling auto-formatting in my IDE :) |
|
CI is failing with Any idea what's happening there? |
yeah, I also prefer Signature. Unsure why we decided initially to use Outer. |
Looking into it. |
I assumed git-clang-format-19 would always call clang-format-10 but doesn't. it calls the system clang-format which in the CI runners is clang-format-16 which don't support |
|
See #4666 |
|
With that PR merged, this should be trivial once rebased? |
pmatos
force-pushed
the
feature/reformat-clang-format-19
branch
from
1d73276 to
4473054
Compare
Good to go, I think. |
3 participants
No description provided.