Skip to content

Restore arm64 docker image support#212

Merged
dennisvang merged 4 commits intodevelopfrom
fix/issue188
Jul 15, 2025
Merged

Restore arm64 docker image support#212
dennisvang merged 4 commits intodevelopfrom
fix/issue188

Conversation

@dennisvang
Copy link
Copy Markdown
Contributor

@dennisvang dennisvang commented Jul 3, 2025

This fixes the build issue that prevented us from creating an arm64 image:

  • replaced deprecated node-sass dependency by latest sass
    (according to sass docs, both packages expose the same JS API)
  • added explicit type cast to fix error arising after sass upgrade
  • re-enabled multi-platform docker images

fixes #188

@dennisvang
Copy link
Copy Markdown
Contributor Author

dennisvang commented Jul 3, 2025

We can work around the gyp related build issue by migrating from the deprecated node-sass to the most recent sass.

Now install succeeds, but we run into another issue in the build phase:

...
 => [build-stage 3/8] COPY package*.json ./                                                                                                                                        0.0s
 => [build-stage 4/8] RUN npm install                                                                                                                                             49.9s
 => [build-stage 5/8] COPY . .                                                                                                                                                     0.1s 
 => ERROR [build-stage 6/8] RUN npm run build                                                                                                                                     89.7s 
------                                                                                                                                                                                  
 > [build-stage 6/8] RUN npm run build:                                                                                                                                                 
0.893                                                                                                                                                                                   
0.893 > [email protected] build                                                                                                                                                         
0.893 > vue-cli-service build                                                                                                                                                           
0.893                                                                                                                                                                                   
1.766 
1.768 -  Building legacy bundle for production...
89.51  ERROR  Failed to compile with 1 error1:07:28 PM
89.51 
89.51  error  in src/components/SearchField/index.vue:37:5
89.51 
89.51 TS2322: Type 'string | string[]' is not assignable to type 'string'.
89.51   Type 'string[]' is not assignable to type 'string'.
89.51     35 |   @Watch('$route')
89.51     36 |   setQ() {
89.51   > 37 |     this.routeQ = _.get(this.$route, 'query.q', '')
89.51        |     ^^^^^^^^^^^
89.51     38 |     this.q = this.routeQ
89.51     39 |   }
89.51     40 | }
89.51 
89.51  ERROR  Error: Build failed with errors.
89.51 Error: Build failed with errors.
89.51     at /app/node_modules/@vue/cli-service/lib/commands/build/index.js:207:23
89.51     at /app/node_modules/webpack/lib/webpack.js:168:8
89.51     at /app/node_modules/webpack/lib/HookWebpackError.js:67:2
89.51     at Hook.eval [as callAsync] (eval at create (/app/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1)
89.51     at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/app/node_modules/webpack/node_modules/tapable/lib/Hook.js:20:14)
89.51     at Cache.shutdown (/app/node_modules/webpack/lib/Cache.js:156:23)
89.51     at /app/node_modules/webpack/lib/Compiler.js:1376:15
89.51     at Hook.eval [as callAsync] (eval at create (/app/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1)
89.51     at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/app/node_modules/webpack/node_modules/tapable/lib/Hook.js:20:14)
89.51     at Compiler.close (/app/node_modules/webpack/lib/Compiler.js:1369:23)
89.51     at /app/node_modules/webpack/lib/webpack.js:167:16
89.51     at finalCallback (/app/node_modules/webpack/lib/Compiler.js:496:32)
89.51     at /app/node_modules/webpack/lib/Compiler.js:520:13
89.51     at Hook.eval [as callAsync] (eval at create (/app/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:33:1)
89.51     at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/app/node_modules/webpack/node_modules/tapable/lib/Hook.js:20:14)
89.51     at onCompiled (/app/node_modules/webpack/lib/Compiler.js:518:21)
89.51     at /app/node_modules/webpack/lib/Compiler.js:1347:17
89.51     at eval (eval at create (/app/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:14:1)
------
Dockerfile:13
--------------------
  11 |     # build-layer
  12 |     COPY . .
  13 | >>> RUN npm run build
  14 |     
  15 |     # update version info
--------------------

Actually this error also occurs if we run npm run serve after the sass upgrade. It's just a typescript error that did not surface before...

@dennisvang dennisvang force-pushed the fix/issue188 branch 2 times, most recently from 8784f3a to a74e66e Compare July 3, 2025 14:39
@dennisvang dennisvang marked this pull request as ready for review July 3, 2025 14:43
@dennisvang dennisvang merged commit 94b05d7 into develop Jul 15, 2025
6 checks passed
@dennisvang dennisvang deleted the fix/issue188 branch July 15, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restore arm64 support for Docker image

2 participants