separate build and publish workflows#166
Merged
dennisvang merged 5 commits intodevelopfrom Mar 3, 2025
Merged
Conversation
Contributor
dennisvang
commented
Feb 27, 2025
dennisvang
commented
- multi-stage Dockerfile (fixes Use multi-stage dockerfile #165)
- separate build and publish workflows, with reusable workflows (fixes Separate test and deployment workflows, remove nexus deployment. #162)
- clean up Dockerfile and .dockerignore accordingly - move build_info.sh call from github action into build stage - convert build_info.sh from bash to sh (alpine has no bash)
using reusable workflows from FAIRDataTeam/github-workflows
Closed
Contributor
Author
|
Build succeeds for Options:
EDIT: Actually arm64 support is desirable, otherwise we are limited in the choice of server type. Also, think about developers on mac. So we've opened an issue to restore support, depending on the upgrade of all node dependencies to the most recent versions: #188 |
Contributor
Author
|
Hi @MarekSuchanek, I guess this is about ready, what do you think? A squash merge would be appropriate here. We can then merge into #140, which introduces some additional simplifications to the Dockerfile. |
dennisvang
added a commit
that referenced
this pull request
May 16, 2025
* add build stage to Dockerfile - clean up Dockerfile and .dockerignore accordingly - move build_info.sh call from github action into build stage - convert build_info.sh from bash to sh (alpine has no bash) * separate build and publish workflows using reusable workflows from FAIRDataTeam/github-workflows * explicit stage name in Dockerfile * limit docker image support to linux/amd64 * add minimal sass dependencies in Dockerfile
dennisvang
added a commit
that referenced
this pull request
May 16, 2025
* add build stage to Dockerfile - clean up Dockerfile and .dockerignore accordingly - move build_info.sh call from github action into build stage - convert build_info.sh from bash to sh (alpine has no bash) * separate build and publish workflows using reusable workflows from FAIRDataTeam/github-workflows * explicit stage name in Dockerfile * limit docker image support to linux/amd64 (workaround because linux/arm64 fails, due to missing node-gyp support) * add minimal sass dependencies in Dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.