Merged
Conversation
8040c78 to
e5ca9ae
Compare
e5ca9ae to
5c2b0e5
Compare
Contributor
|
related to
|
Contributor
|
@MarekSuchanek Do you know more about the status of this PR? Is it complete or still work in progress? |
Contributor
|
@dennisvang this can be merged once CI works well again... and then we can make PR + merge it for |
Contributor
|
Thanks @MarekSuchanek . I'll merge the changes from develop and fix the conflicts. |
- separate github workflows - multi-stage dockerfile
MarekSuchanek
approved these changes
Mar 4, 2025
dennisvang
added a commit
that referenced
this pull request
Jul 7, 2025
* Merge index into client image * Add index FDP permits --------- Co-authored-by: dennisvang <[email protected]>
dennisvang
added a commit
that referenced
this pull request
Jul 16, 2025
* Merge index into client image * Add index FDP permits --------- Co-authored-by: Jan Slifka <[email protected]>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(description by dennisvang)
This PR introduces support for the "index gatekeeper", a.k.a. index permits.
Admin users can now decide whether or not to include an FDP into the index.
When a ping is received from an unknown FDP, it is not included in the list, but gets a pending status.
The admin can review, and then accept or reject the FDP.
In addition, this PR enables the client to deal with both normal fdps and fdp-indexes, without explicit (docker) configuration.
As a result, there is no longer the need for separate fdp-client and fdp-index-client docker images.
The client automatically recognizes that an fdp is an index, by checking the
indexmember in the response from the fdp's/configs/bootstrapendpoint (see e.g. https://app.fairdatapoint.org/swagger-ui/index.html#/Client/getBootstrapConfig).Changes as summarized by Copilot: