Exclude commons-logging dependency from rdf-resource-resolver-core#805
Merged
dennisvang merged 2 commits intodevelopfrom Nov 18, 2025
Merged
Exclude commons-logging dependency from rdf-resource-resolver-core#805dennisvang merged 2 commits intodevelopfrom
dennisvang merged 2 commits intodevelopfrom
Conversation
MarekSuchanek
approved these changes
Nov 15, 2025
Contributor
MarekSuchanek
left a comment
MarekSuchanek
left a comment
There was a problem hiding this comment.
Good 👍🏻 I see it documented in the GitHub issue, would it make sense to add comment directly in pom.xml to clarify why exclusion is needed (this might be used for other older exclusions as well though)?
Contributor
Author
Good idea. I'll add a comment. That would also make sense for the other (existing) exclusions. I'll try to figure out the reason for excluding them. Two are also related to logging, one is related to tests. |
No comments for the remaining two exclusions, because it's not clear why they were excluded. Typically this is to prevent some dependency conflict, but found no clear reason in commits, nor online, nor did immediate issues arise after temporarily removing the exclusions.
dennisvang
added a commit
that referenced
this pull request
Jan 29, 2026
…olver-core (#805) This prevents the warning "Standard Commons Logging discovery in action with spring-jcl: please remove commons-logging.jar from classpath in order to avoid potential conflicts" * exclude commons-logging dependency from rdf-resource-resolver-core * add comments in pom with reason for exclusion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #800 (see issue for details)