Skip to content

Consistent datatype and editor for date/datetime#765

Merged
dennisvang merged 6 commits intosupport/1.17.xfrom
fix/issue762
Sep 5, 2025
Merged

Consistent datatype and editor for date/datetime#765
dennisvang merged 6 commits intosupport/1.17.xfrom
fix/issue762

Conversation

@dennisvang
Copy link
Copy Markdown
Contributor

@dennisvang dennisvang commented Sep 4, 2025

Fixes the inconsistency between sh:datatype and dash:editor in the default FDP schemas:

  • Changed dash:DatePickerEditor to dash:DateTimePickerEditor for the following fields in the dataset and distribution shapes, to be consistent with the xsd:dateTime datatype:

    • dct:issued
    • dct:modified
  • Changed xsd:dateTime to xsd:date for the following fields in the fdp shape. This fixes the inconsistency between the current default schema and the FDP spec (see fdp-specs-v1.2), as well as the inconsistency between editor and datatype:

    • fdp:startDate
    • fdp:endDate

See diff for details. Note that the migration 0017*.ttl files should be compared with the corresponding 0016*.ttl files to see the changes.

fixes #762
fixes #504

- dct:issued
- dct:modified
- fdp:metadataIssued
- fdp:metadataModified
- r3d:lastUpdate
@dennisvang dennisvang changed the base branch from develop to support/1.17.x September 4, 2025 15:50
@dennisvang
Copy link
Copy Markdown
Contributor Author

dennisvang commented Sep 5, 2025

Hm... Looks like I wasn't paying attention there:

Clearly we should create a new production migration instead of changing the existing one.

Converting back to draft...

@dennisvang dennisvang marked this pull request as draft September 5, 2025 09:14
only difference with previous versions is in the sh:datatype and dash:editor values

note that the `repository` shape from migration 0005 also has some date fields, but this shape was removed again in migration 0011
@dennisvang dennisvang marked this pull request as ready for review September 5, 2025 11:26
Copy link
Copy Markdown
Member

@luizbonino luizbonino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine.

@dennisvang dennisvang merged commit b55fb11 into support/1.17.x Sep 5, 2025
13 checks passed
@dennisvang dennisvang deleted the fix/issue762 branch September 5, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants