Merged
Conversation
MarekSuchanek
force-pushed
the
feature/index-filtering
branch
from
d8a86fe to
79892e1
Compare
MarekSuchanek
force-pushed
the
feature/index-filtering
branch
from
79892e1 to
5cbcc61
Compare
kburger
approved these changes
Sep 6, 2023
src/main/java/nl/dtls/fairdatapoint/entity/index/settings/IndexSettings.java
Outdated
Show resolved
Hide resolved
MarekSuchanek
force-pushed
the
feature/index-filtering
branch
11 times, most recently
from
63b43da to
e740014
Compare
MarekSuchanek
force-pushed
the
feature/index-filtering
branch
2 times, most recently
from
ec09d57 to
69d44dd
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/java/nl/dtls/fairdatapoint/api/controller/index/IndexAdminController.java
Fixed
Show fixed
Hide fixed
MarekSuchanek
force-pushed
the
feature/index-filtering
branch
from
69d44dd to
97ff0cf
Compare
MarekSuchanek
force-pushed
the
feature/index-filtering
branch
from
97ff0cf to
f169fff
Compare
MarekSuchanek
force-pushed
the
feature/index-filtering
branch
from
f169fff to
a8c86ea
Compare
Contributor
Author
|
@kburger I added the configuration default value for auto-permit and also actions on permit change (deleting harvested data and triggering retrieval if accepted). Could you please check one more time so we can merge this? |
kburger
approved these changes
Oct 31, 2023
Contributor
|
Is this related to FAIRDataTeam/jira-backlog-migration#32? |
Closed
8 tasks
Contributor
|
Note the present PR (#454) predates the move to postgres (#519), so it still uses mongodb. The following related issues were created after the move to postgres:
In case of a backport to v1.17.x, we should check if any of these issues also apply to the present PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a moderation mechanism for index entries by adding support for permit states. Index entries, which are automatically created when any service pings the FDP index, can now be reviewed and assigned a state:
PENDING,ACCEPTED, orREJECTED. This allows more control over what gets publicly listed and prevents unwanted or invalid records from appearing in the index without review.PENDING,ACCEPTED,REJECTED) make it easy to track and act on entries.