-
Notifications
You must be signed in to change notification settings - Fork 39
Inconsistent failure of acceptance test index.ping.List_POST.res204_newEntry #839
Description
On the support/v1.18.x branch, the test nl.dtls.fairdatapoint.acceptance.index.ping.List_POST.res204_newEntry fails on ubuntu runner, but succeeds on macos runner.
On ubuntu:
- succeeds if we run the test individually (except sometimes it does not...)
- succeeds if we run only the tests in
nl.dtls.fairdatapoint.acceptance.index.ping.List_POST - fails if we run all tests in
nl.dtls.fairdatapoint.acceptance.index, or more
Bisected this down to e3dd9c8, but not sure why the same test did not fail at that time...
Failure related to ping acceptance: nl.dtls.fairdatapoint.service.index.event.EventService.acceptIncomingPing
FAIRDataPoint/src/main/java/nl/dtls/fairdatapoint/service/index/event/EventService.java
Line 148 in 2888362
| final IndexEntry indexEntry = indexEntryService.storeEntry(reqDto); |
"java.lang.NullPointerException: Cannot invoke "java.lang.Boolean.booleanValue()" because the return value of "nl.dtls.fairdatapoint.entity.index.settings.IndexSettings.getAutoPermit()" is null"
that's here:
FAIRDataPoint/src/main/java/nl/dtls/fairdatapoint/service/index/entry/IndexEntryService.java
Line 242 in 2888362
| if (settings.getAutoPermit()) { |
Looks like there is some interdependency in the tests causing the autoPermit value to be either null or true/false, depending on the order in which tests are ran.
In fact, in those cases where the test succeeds, it turns out to be falling back on the default index settings, but when it fails, it turns out to be using index settings from the database.