Skip to content

Closes #959 Hadamard import FME#960

Merged
jan-petr merged 8 commits intodevelopfrom
bug-#959_HadamardImportBremen
Dec 1, 2021
Merged

Closes #959 Hadamard import FME#960
jan-petr merged 8 commits intodevelopfrom
bug-#959_HadamardImportBremen

Conversation

@jan-petr
Copy link
Contributor

@jan-petr jan-petr commented Nov 30, 2021

Linked issue

#959

@jan-petr jan-petr self-assigned this Nov 30, 2021
@jan-petr jan-petr linked an issue Nov 30, 2021 that may be closed by this pull request
Bremen Hadamard import and initialization #959
Closed
MichaelStritt
MichaelStritt approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@MichaelStritt MichaelStritt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice changes, they nicely clean up Beatriz' code

@MichaelStritt
Copy link
Contributor

MichaelStritt commented Nov 30, 2021

Running the flavors now

@MichaelStritt MichaelStritt added the bug Something isn't working label Nov 30, 2021
@MichaelStritt
Copy link
Contributor

MichaelStritt commented Dec 1, 2021

So I updated the flavors and ran everything (without the processing) again. Is it possible that this is an os related defect?

COMPARISON TABLE:
                       flavor                               dataset                      name                                            message                              
    _____________________________________________    ______________________    ________________________    ___________________________________________________________________

    'Siemens_PCASL_3DGRASE_VD13A_Hadamard4-FME_1'    'rawdata'                 'Missing file'              '\sub-Sub1\perf\sub-Sub1_asl.json'                                 
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard4-FME_1'    'rawdata'                 'Missing file'              '\sub-Sub1\perf\sub-Sub1_asl.nii.gz'                               
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard4-FME_1'    'rawdata'                 'Missing file'              '\sub-Sub1\perf\sub-Sub1_aslcontext.tsv'                           
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard4-FME_1'    'rawdata'                 'Missing file'              '\sub-Sub1\perf\sub-Sub1_m0scan.json'                              
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard4-FME_1'    'rawdata'                 'Missing file'              '\sub-Sub1\perf\sub-Sub1_m0scan.nii.gz'                            
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard8-FME_1'    'rawdata'                 'Missing file'              '\sub-Sub1\perf\sub-Sub1_asl.json'                                 
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard8-FME_1'    'rawdata'                 'Missing file'              '\sub-Sub1\perf\sub-Sub1_asl.nii.gz'                               
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard8-FME_1'    'rawdata'                 'Missing file'              '\sub-Sub1\perf\sub-Sub1_aslcontext.tsv'                           
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard8-FME_1'    'rawdata'                 'Missing file'              '\sub-Sub1\perf\sub-Sub1_m0scan.json'                              
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard8-FME_1'    'rawdata'                 'Missing file'              '\sub-Sub1\perf\sub-Sub1_m0scan.nii.gz'                            
    'Philips_PCASL_2DEPI_3.2.2.1_2'                  'Both'                    'Different file content'    'Different file content: \ExploreASL\dataset_description.json'     
    'Philips_PCASL_2DEPI_3.2.2.1_2'                  'Both'                    'Different file content'    'Different file content: \ExploreASL\sub-ABC301_1\ASL_1\ASL4D.json'
    'Philips_PCASL_2DEPI_3.2.2.1_2'                  'Both'                    'Different file content'    'Different file content: \ExploreASL\sub-ABC301_1\ASL_1\M0.json'   
    'Philips_PCASL_2DEPI_3.2.2.1_2'                  'Both'                    'Different file content'    'Different file content: \ExploreASL\sub-ABC301_1\FLAIR.json'      
    'Philips_PCASL_2DEPI_3.2.2.1_2'                  'Both'                    'Different file content'    'Different file content: \ExploreASL\sub-ABC301_1\T1.json'         
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard4-FME_1'    'derivativesReference'    'Missing folder'            '\ExploreASL\temp'                                                 
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard4-FME_1'    'derivatives'             'Missing folder'            '\ExploreASL\sub-Sub1_1\ASL_1'                                     
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard4-FME_1'    'derivativesReference'    'Missing file'              '\ExploreASL\temp\dcm2niiCatchedErrors.json'                       
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard4-FME_1'    'derivativesReference'    'Missing file'              '\ExploreASL\temp\dcm2niiCatchedErrors.mat'                        
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard4-FME_1'    'derivatives'             'Missing file'              '\ExploreASL\sub-Sub1_1\ASL_1\ASL4D.json'                          
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard4-FME_1'    'derivatives'             'Missing file'              '\ExploreASL\sub-Sub1_1\ASL_1\ASL4D.nii.gz'                        
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard4-FME_1'    'derivatives'             'Missing file'              '\ExploreASL\sub-Sub1_1\ASL_1\ASL4D_aslcontext.tsv'                
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard4-FME_1'    'derivatives'             'Missing file'              '\ExploreASL\sub-Sub1_1\ASL_1\M0.json'                             
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard4-FME_1'    'derivatives'             'Missing file'              '\ExploreASL\sub-Sub1_1\ASL_1\M0.nii.gz'                           
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard8-FME_1'    'derivativesReference'    'Missing folder'            '\ExploreASL\temp'                                                 
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard8-FME_1'    'derivatives'             'Missing folder'            '\ExploreASL\sub-Sub1_1\ASL_1'                                     
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard8-FME_1'    'derivativesReference'    'Missing file'              '\ExploreASL\temp\dcm2niiCatchedErrors.json'                       
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard8-FME_1'    'derivativesReference'    'Missing file'              '\ExploreASL\temp\dcm2niiCatchedErrors.mat'                        
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard8-FME_1'    'derivatives'             'Missing file'              '\ExploreASL\sub-Sub1_1\ASL_1\ASL4D.json'                          
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard8-FME_1'    'derivatives'             'Missing file'              '\ExploreASL\sub-Sub1_1\ASL_1\ASL4D.nii.gz'                        
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard8-FME_1'    'derivatives'             'Missing file'              '\ExploreASL\sub-Sub1_1\ASL_1\ASL4D_aslcontext.tsv'                
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard8-FME_1'    'derivatives'             'Missing file'              '\ExploreASL\sub-Sub1_1\ASL_1\M0.json'                             
    'Siemens_PCASL_3DGRASE_VD13A_Hadamard8-FME_1'    'derivatives'             'Missing file'              '\ExploreASL\sub-Sub1_1\ASL_1\M0.nii.gz'                           

LOGGING TABLE:

@MichaelStritt MichaelStritt mentioned this pull request Dec 1, 2021
Closed
@MichaelStritt MichaelStritt changed the title Bug #959 hadamard import bremen Closes #959 Hadamard import FME Dec 1, 2021
MDijsselhof
MDijsselhof approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@MDijsselhof MDijsselhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

BeatrizPadrela
BeatrizPadrela approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@BeatrizPadrela BeatrizPadrela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes, looks very nice!

@jan-petr jan-petr force-pushed the bug-#959_HadamardImportBremen branch from 94940ad to 89f0182 Compare December 1, 2021 20:32
@jan-petr jan-petr merged commit 89f0182 into develop Dec 1, 2021
@jan-petr jan-petr deleted the bug-#959_HadamardImportBremen branch December 1, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BeatrizPadrela BeatrizPadrela BeatrizPadrela approved these changes

@MDijsselhof MDijsselhof MDijsselhof approved these changes

+1 more reviewer

@MichaelStritt MichaelStritt MichaelStritt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jan-petr jan-petr

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bremen Hadamard import and initialization

4 participants

@jan-petr @MichaelStritt @BeatrizPadrela @MDijsselhof