Skip to content

Closes #712 Data type comparison#951

Merged
MichaelStritt merged 4 commits intodevelopfrom
bug-#712_NiftiComparison
Nov 29, 2021
Merged

Closes #712 Data type comparison#951
MichaelStritt merged 4 commits intodevelopfrom
bug-#712_NiftiComparison

Conversation

@MichaelStritt
Copy link
Contributor

@MichaelStritt MichaelStritt commented Nov 29, 2021 •
edited
Loading

Linked issue

Check out #712

How to test

Required: if not defined in the linked issue, add a simple test description here

Comments

Does this work for you?

@MichaelStritt MichaelStritt self-assigned this Nov 29, 2021
@MichaelStritt MichaelStritt added the minor improvements Fixes that don't change main pipeline functionality label Nov 29, 2021
@MichaelStritt MichaelStritt linked an issue Nov 29, 2021 that may be closed by this pull request
bids_FullPipelineTest: Nifti comparisons have unequal data format #712
Closed
jan-petr
jan-petr requested changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things. Otherwise good.

@jan-petr jan-petr removed the request for review from HenkMutsaerts November 29, 2021 10:38
@MichaelStritt
Copy link
Contributor Author

MichaelStritt commented Nov 29, 2021

Unit test

>> UnitTest = xASL_ut_function_xASL_im_CompareNiftis(TestRepository);
Identical: true
RMSE:      0.00
Min.diff.: 0.00
Max.diff.: 0.00
Identical: false
RMSE:      4.45
Min.diff.: 0.00
Max.diff.: 57.00

@MichaelStritt MichaelStritt force-pushed the bug-#712_NiftiComparison branch from 3c9c75e to 61a6bfe Compare November 29, 2021 11:08
jan-petr
jan-petr approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@MichaelStritt MichaelStritt force-pushed the bug-#712_NiftiComparison branch from 61a6bfe to bbdbbf0 Compare November 29, 2021 11:13
@MichaelStritt MichaelStritt merged commit bbdbbf0 into develop Nov 29, 2021
@MichaelStritt MichaelStritt deleted the bug-#712_NiftiComparison branch November 29, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-petr jan-petr jan-petr approved these changes

Assignees

@MichaelStritt MichaelStritt

Labels

minor improvements Fixes that don't change main pipeline functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bids_FullPipelineTest: Nifti comparisons have unequal data format

2 participants

@MichaelStritt @jan-petr