Closes Bug #938 redundant dcm2nii behavior#939
Merged
MichaelStritt merged 5 commits intodevelopfrom Nov 26, 2021
Merged
Conversation
jan-petr
approved these changes
Nov 25, 2021
Contributor
jan-petr
left a comment
There was a problem hiding this comment.
Looks good to me. Michael should approve as well and check if there won't be any indirect issues with moving the lines (I don't foresee anything).
Contributor
|
Many things need to be changed to make this work for PAR-REC again.
|
Contributor
|
Contributor
|
Hm... cool that we don't check in three places of the workflow now, but if it doesn't work at all right now, we should definitely work on the actual bugfix. It also seems a bit risky just to check if file or folder is called PAR. We should probably restrict it to bMatchDirectories=false, so that it only works for DICOM files starting with PAR? |
Contributor
|
The nicest solution would probably be if there was a specific DICOM tag for those datasets. |
5e49e3e to
53dedef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #938