Merged
Conversation
HenkMutsaerts
approved these changes
Nov 21, 2021
HenkMutsaerts
requested changes
Nov 21, 2021
Member
HenkMutsaerts
left a comment
HenkMutsaerts
left a comment
There was a problem hiding this comment.
Sorry I approved too fast :)
I would add some more feedback to the user. "No matching files" could mean anything to the user, so perhaps 1 or 2 lines explaining to the user what could be wrong (like you say in your comment, which the user that doesn't dig into the code, won't see).
Thinking about it, it would be nice if Matlab had some sort of comment/fprintf linking in case of errors :)
Contributor
Author
|
@HenkMutsaerts: Please check if you're happy with the new version. It includes a link to the documentation, because otherwise we would have to explain how the
|
MichaelStritt
changed the title
MichaelStritt
force-pushed
the
bug-#929_Import
branch
from
9bd3b8a to
c524a5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
#929