Closes #911 xASL_module_ASL: Revamp initialization#912
Merged
Conversation
MichaelStritt
approved these changes
Nov 15, 2021
Contributor
MichaelStritt
left a comment
MichaelStritt
left a comment
There was a problem hiding this comment.
@HenkMutsaerts: I did some minor changes. I just love putting code to sub-functions to make the code more readable. I saw that you already did the 10 test datasets and I didn't redo them.
jan-petr
requested changes
Nov 15, 2021
Contributor
jan-petr
left a comment
jan-petr
left a comment
There was a problem hiding this comment.
Looks very good. But these revamps are never really without small errors - see my comments ;)
HenkMutsaerts
commented
Nov 16, 2021
Member
Author
HenkMutsaerts
left a comment
HenkMutsaerts
left a comment
There was a problem hiding this comment.
Minor question, and I cannot easily see that everything is nicely put into submodules but I assume this ;)
And I cannot approve
jan-petr
force-pushed
the
feature-#911_Revamp_xASL_module_ASL
branch
from
57c59d8 to
495c9a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #911