Skip to content

Fixes #848 xASL_bids_BIDSifyAnatJSON: check parameter size, raise warning#849

Merged
MichaelStritt merged 1 commit intodevelopfrom
bug-#848_InputCheck
Sep 30, 2021
Merged

Fixes #848 xASL_bids_BIDSifyAnatJSON: check parameter size, raise warning#849
MichaelStritt merged 1 commit intodevelopfrom
bug-#848_InputCheck

Conversation

@MichaelStritt
Copy link
Contributor

Linked issue

Check out #848

How to test

@BeatrizPadrela: please test this with the twins data

Comments

Optional: add helpful comments for the reviewers here

@MichaelStritt MichaelStritt added the bug Something isn't working label Sep 22, 2021
@MichaelStritt MichaelStritt linked an issue Sep 22, 2021 that may be closed by this pull request
@MichaelStritt
Copy link
Contributor Author

@BeatrizPadrela: I assigned you, so if you think this is fine, move it to @jan-petr's bucket. If he agrees, he can move it back to your bucket and you can merge it yourself.

@BeatrizPadrela
Copy link
Contributor

It works and gives no errors!!
Is it normal that it creates a folder for T1 and not for FLAIR?
image

@MichaelStritt
Copy link
Contributor Author

It works and gives no errors!!
Is it normal that it creates a folder for T1 and not for FLAIR?

@BeatrizPadrela: I think so. At least in temp. In derivatives we should have the normal ExploreASL legacy structure though. Can you approve the PR if you're fine with it? I already moved it to @jan-petr's bucket.

Copy link
Contributor

@BeatrizPadrela BeatrizPadrela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Please complete the "Release note" before merging.

@MichaelStritt MichaelStritt merged commit 1723e7e into develop Sep 30, 2021
@MichaelStritt MichaelStritt deleted the bug-#848_InputCheck branch September 30, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BIDSifyAnatJSON crashes because of RepTime array

3 participants