Merged
Conversation
Closed
HenkMutsaerts
requested changes
Aug 17, 2021
jan-petr
commented
Aug 18, 2021
Contributor
Author
jan-petr
left a comment
jan-petr
left a comment
There was a problem hiding this comment.
I have fixed all the comments and added more values for different field-strength, plus supplemented all the references.
Contributor
Author
|
@HenkMutsaerts Can you please check the code and comments. And resolve them. Also, can you try to find some references for the T2? |
HenkMutsaerts
approved these changes
Aug 23, 2021
HenkMutsaerts
force-pushed
the
feature-#442_quantify7T
branch
from
a80fd58 to
20e7df2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
#442
How to test
Does not change anything for 3T. Runs rather fine - TestDataSet should be a good test.
Comments
But the values have to be proved and also added for other fields - where currently missing.