Conversation
MichaelStritt
added
import
MichaelStritt
changed the title
jan-petr
requested changes
Aug 17, 2021
Contributor
jan-petr
left a comment
jan-petr
left a comment
There was a problem hiding this comment.
Minor admin stuff. Couldn't discover large issues.
Modules/SubModule_Import/xASL_bids_BIDS2Legacy_CompilePathsForCopying.m
Outdated
Show resolved
Hide resolved
xASL_imp_DCM2NII_Initialize was a misleading name. We mostly read and initialize imPar here. This is mostly based on the sourceStructure.json. I think as a name xASL_imp_Initialize is a bit more straightforward and shorter. Otherwise you would expect this part to be within the DCM2NII submodule.
The problem with the way that Henk fixed #769 is that it now tries to load the dataset even if we only ran one of the first import modules. To fix this, we need to ensure that either a derivatives directory or a legacy dataset exists. I think the current method should be able to capture most use-cases, but we sould really start to stop supporting this outdated usage of ExploreASL, it makes the code super complex.
Another minor fix related to #769. We do not want the warning to pop up if we only initialize.
jan-petr
force-pushed
the
optimize-#778_Import
branch
from
77a1e39 to
d44018c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
#778
Comment
@jan-petr: In some of the commits I added extra detailed comments on what I did. I think this overall improves the import a lot. I basically did the changes that I described in the WhatsApp group (related to the flow charts) and also fixed some bugs related to #769.
Simplified description
xASL_..._Bids2LegacytoxASL_module_ImportxASL_imp_DCM2NII_Initializeconditional / rename itxASL_..._Bids2Legacy