Fixes #761 xASL_module_ASL: Minor fix for empty images#764
Merged
HenkMutsaerts merged 2 commits intodevelopfrom Aug 5, 2021
Merged
Fixes #761 xASL_module_ASL: Minor fix for empty images#764HenkMutsaerts merged 2 commits intodevelopfrom
HenkMutsaerts merged 2 commits intodevelopfrom
Conversation
MichaelStritt
changed the title
Closed
HenkMutsaerts
approved these changes
Aug 4, 2021
Member
HenkMutsaerts
left a comment
HenkMutsaerts
left a comment
There was a problem hiding this comment.
Nice, though I don't understand the additional (), you don't need these.
Otherwise, good!
HenkMutsaerts
assigned
MDijsselhof and
HenkMutsaerts and unassigned
BeatrizPadrela and
MDijsselhof
HenkMutsaerts
force-pushed
the
bug-#761_CatchEmptyImages
branch
from
5e0684b to
ad05f78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
#761
Comments
@BeatrizPadrela & @HenkMutsaerts: would be cool if you would test this to validate that it's working correctly.