Fixes #739 Introduce function to fix basic fields within JSON files#742
Merged
MichaelStritt merged 13 commits intodevelopfrom Jul 30, 2021
Merged
Fixes #739 Introduce function to fix basic fields within JSON files#742MichaelStritt merged 13 commits intodevelopfrom
MichaelStritt merged 13 commits intodevelopfrom
Conversation
Contributor
Author
Beatriz test |
BeatrizPadrela
approved these changes
Jul 27, 2021
Contributor
BeatrizPadrela
left a comment
BeatrizPadrela
left a comment
There was a problem hiding this comment.
works with and without "Manufacturer" field in the Studypar!
Contributor
Author
MichaelStritt
changed the title
MichaelStritt
commented
Jul 29, 2021
Contributor
Author
jan-petr
requested changes
Jul 29, 2021
Contributor
jan-petr
left a comment
jan-petr
left a comment
There was a problem hiding this comment.
Gave it another thought and I think that we should keep it the way it is - except for fixing a few small bugs ;)
I introduced xASL_bids_BIDSifyFixBasicFields and improved the logging within the import script. All changes are only import related and should therefore not affect issue 717 that much.
MichaelStritt
force-pushed
the
import-#739_MissingTags
branch
from
c0d6cf4 to
69a5cc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Check out #739
How to test
Run import of twins datasets with and without Manufacturer in
studyPar.json(hopefully it works both times).Comments
I introduced
xASL_bids_BIDSifyFixBasicFieldsand improved the logging within the import master script. All changes are only import related and should therefore not affect issue #717 that much. Would be helpful to know if that's the right place for some of the functions or if we should move that functionality to another part @jan-petr.