Conversation
HenkMutsaerts
requested changes
Jul 12, 2021
Member
HenkMutsaerts
left a comment
HenkMutsaerts
left a comment
There was a problem hiding this comment.
Figures look good, but the file name is weird, it says: Tra_Temp_qCBF_sub-Sub1_ASL_1_rc2T1_ASL_res.jpg, so "Temp" instead of "Contour", and I don't understand why it says "rc2T1_ASL_res" instead of "PV_pWM" (as we said we wanted to copy the filenames in the new figure name) but perhaps this is something that was already there.
HenkMutsaerts
approved these changes
Jul 13, 2021
Member
HenkMutsaerts
left a comment
HenkMutsaerts
left a comment
There was a problem hiding this comment.
Nice. I would have removed the Booleans, before we know it we have 1000s of them ;)
jan-petr
force-pushed
the
optimize-#721_ContourFix
branch
from
f6f2cc1 to
1cc9ebd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
#721
Comments
I have tested 10 TestDataSets and all runs good. Plus for the first, I have tested contours and contours from template and the QC in ASLcheck also looks good.