@BeatrizPadrela: I think you have the data access, right? Can you run a small test?

@BeatrizPadrela: I think you have the data access, right? Can you run a small test?

Sure, will do now!

the vectorOldOrder seems to be okay
But @jan-petr this printscreen is from asl.json. Shouldn't the PLD vector be [1,1,1,1,1,1,1,1,1,2,2,2,2,]?

the vectorOldOrder seems to be okay
But @jan-petr this printscreen is from asl.json. Shouldn't the PLD vector be [1,1,1,1,1,1,1,1,1,2,2,2,2,]?

Thanks. Trivial mistake. Fixed.

@BeatrizPadrela: After this is merged, we could update the rawdata & derivatives folders in the FME sequence repository, so that it's easier for @amahroo and you to work with it.

@BeatrizPadrela: After this is merged, we could update the rawdata & derivatives folders in the FME sequence repository, so that it's easier for @amahroo and you to work with it.

Yes. That would be good. @BeatrizPadrela can you check if this is fine now for both had4 and had8 and approve. I'll merge it then. Thanks.

@BeatrizPadrela: After this is merged, we could update the rawdata & derivatives folders in the FME sequence repository, so that it's easier for @amahroo and you to work with it.

Yes. That would be good. @BeatrizPadrela can you check if this is fine now for both had4 and had8 and approve. I'll merge it then. Thanks.

We could also think about adding one Hadamard-4 and one Hadamard-8 case to the flavor database. I think we even talked about it with Amnah before, right?

@BeatrizPadrela: After this is merged, we could update the rawdata & derivatives folders in the FME sequence repository, so that it's easier for @amahroo and you to work with it.

Yes. That would be good. @BeatrizPadrela can you check if this is fine now for both had4 and had8 and approve. I'll merge it then. Thanks.

We could also think about adding one Hadamard-4 and one Hadamard-8 case to the flavor database. I think we even talked about it with Amnah before, right?

That's a good idea Michael. I will now test this so we can merge

So for Hadamard-4 everything works!

Now I'm trying to get Hadamard-8 data to test this. @MichaelStritt do you know how to sort the dicoms into two folders of ASL and M0? (like you did for Hadamard-4)

@BeatrizPadrela & @jan-petr: I've added a Hadamard-4 and a Hadamard-8 case to the flavor library. I don't think the Hadamard-8 does work properly yet. The echo times and the PLDs in the asl.json aren't correct. Maybe it is required to check if the regular expressions work correctly.

Edit: We never tested Hadamard-8 before though, so if you want to fix this within a separate issue, that's fine by me.

Yes, I also ran the import for Hadamard-8 and the ASL.json looks like this:

@MichaelStritt maybe we can fix this in this issue, or do you think that creating other issue is advantageous?

I would fix it inside this issue already. And make sure that it works on both flavors. Will do that quickly...

I just reran it. It has to be fixed either in xASL_imp_NII2BIDS_SubjectSessionRun or in xASL_imp_DCM2NII_Subject_ShuffleTheDynamics... I think. The regular expression seems to work just fine in both cases.

So here we have for Hadamard-4 3 TIs and 8 TEs. For Hadamard-8 we have 7 TIs and 1 TE.

Edit: The code seems to be able to detect this correctly: FME sequence, Hadamard-8 encoded images, 7 PLDs, 1 TEs.

Fixed. Pull a new version of Flavors. The number of PLDs and HadamardMatrix was set incorrectly. This is now fixed in the references..