Conversation
7 tasks
HenkMutsaerts
requested changes
May 17, 2023
Member
HenkMutsaerts
left a comment
HenkMutsaerts
left a comment
There was a problem hiding this comment.
Here, we assume that the shortest TE of both ASL and M0 is the one that should be equal between both, is that always the case?
E.g., if we have M0_TE = [10 20 30] and ASL_TE = 20, then we will have a problem.
So I would do the following:
- establish the ASL_TE
- establish the M0_TE
- check which ones are overlapping
- use the smallest value of those that are overlapping (3)
- issue warning if the smallest overlapping value differs from the smallest ASL OR smallest M0 TE value
BeatrizPadrela
approved these changes
May 19, 2023
jan-petr
force-pushed
the
bug-#1411_FixMultiTEM0
branch
from
26df0c3 to
bafb9cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Close #1411