Merged
Conversation
11 tasks
jan-petr
requested changes
May 17, 2023
Contributor
jan-petr
left a comment
jan-petr
left a comment
There was a problem hiding this comment.
I fixed one minor mistake. Make sure that the mask includes also lesions etc. Note that we shouldn't null any PWI values. Instead, a proper mask has to be passed to BASIL. So Mathijs+Bea will need to complete this issue.
Lets continue working on this once Mathijs is done with Look-Locker quantification and once we merge everything. So that we can rebase the commits made so far.
MDijsselhof
reviewed
Jul 6, 2023
Contributor
MDijsselhof
left a comment
MDijsselhof
left a comment
There was a problem hiding this comment.
Code looks good, processing works and is very quick
jan-petr
force-pushed
the
feature-#1387_MaskingBASIL
branch
from
574d2d2 to
18905c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #1387
How to test
Before testing starts - we need to complete all tasks Jan added to the issue.
Can you run BASIL & FABBER and see if:
for multi-PLD BASIL (@MDijsselhof):
for multi-TE FABBER (@BeatrizPadrela):
Comments
Optional: add helpful comments for the reviewers here