Conversation
5 tasks
HenkMutsaerts
requested changes
Apr 15, 2023
HenkMutsaerts
requested changes
Apr 18, 2023
Member
HenkMutsaerts
left a comment
HenkMutsaerts
left a comment
There was a problem hiding this comment.
- we need to correctly mention captured groups vs tokens in the comments and warnings.
- all DICOM parameters from different vendors are mixed, these should be nicely into sections per vendor
HenkMutsaerts
approved these changes
Apr 19, 2023
Member
HenkMutsaerts
left a comment
HenkMutsaerts
left a comment
There was a problem hiding this comment.
I did a few extra clarifications in each instance where we have folderHierarchy, do you agree? This also creates extra warnings for Bea for e.g., using sessions double, but that is what we agreed upon (allowing but warning the user).
BTW: for your "revamp"
Should xASL_imp_Initialize line 146 -> token checks go to xASL_imp_CheckImportSettings?
Should xASL_imp_ReadSourceData line 74 also be moved to xASL_imp_CheckImportSettings?
And BTW: what do you think of my commit titles, is it not easier/faster to review (and especially if we would review it again 1 year later ;)
Contributor
|
All good!! |
jan-petr
commented
Apr 19, 2023
jan-petr
force-pushed
the
bug-#1388_ImportFlavors
branch
from
bb25b29 to
e558433
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Close #1388