Conversation
6 tasks
HenkMutsaerts
requested changes
Apr 13, 2023
Member
HenkMutsaerts
left a comment
HenkMutsaerts
left a comment
There was a problem hiding this comment.
- I don't like the
xASL_sub_XXXsee discussion in group Whatsapp - If I understand correctly, you also managed the import such that it creates the correct BIDS with
aslcontext[cbf deltam deltam]? - And you added the flavor to the flavor database?
- the release information is incomplete, you also managed the import right?
Contributor
Author
|
HenkMutsaerts
approved these changes
Apr 15, 2023
Member
HenkMutsaerts
left a comment
HenkMutsaerts
left a comment
There was a problem hiding this comment.
I did a last commit to improve readability, while I was checking xASL_io_SplitsASL. Also, we need to ensure that all vendor-specific changes are in specific vendor sections; if you go on a very long sabbatical we should still be able to easily read all this, and others should be able to (think about Siemens-specific discussions with Kamen, Chris Rorden, etc).
Otherwise, looks very nice of course
jan-petr
force-pushed
the
bug-#1331_GEflavorCBF
branch
from
149d1d5 to
10d30a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Close #1331