Skip to content

Closes #577 bug #577 population sessions#1346

Merged
jan-petr merged 18 commits intodevelopfrom
bug-#577_PopulationSessions
Mar 28, 2023
Merged

Closes #577 bug #577 population sessions#1346
jan-petr merged 18 commits intodevelopfrom
bug-#577_PopulationSessions

Conversation

@HenkMutsaerts
Copy link
Member

Linked issue

Closes #577

How to test

Required: if not defined in the linked issue, add a simple test description here

Comments

Optional: add helpful comments for the reviewers here

@HenkMutsaerts HenkMutsaerts linked an issue Mar 18, 2023 that may be closed by this pull request
10 tasks
@HenkMutsaerts HenkMutsaerts self-assigned this Mar 18, 2023
@HenkMutsaerts
Copy link
Member Author

@MDijsselhof Can you test this in your dataset(s) by rerunning the population module? The first columns in the stats files are created from participants.tsv, which is why you should first remove participants.tsv. Now participants.tsv should be created correctly and the rest should follow.

Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor formal things to be fixed.

@jan-petr jan-petr self-requested a review March 23, 2023 18:25
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

Copy link
Contributor

@MDijsselhof MDijsselhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one small question

@jan-petr jan-petr requested a review from MDijsselhof March 28, 2023 08:48
@jan-petr jan-petr force-pushed the bug-#577_PopulationSessions branch from dfcf657 to 1ff39b1 Compare March 28, 2023 09:26
@jan-petr jan-petr merged commit 1ff39b1 into develop Mar 28, 2023
@jan-petr jan-petr deleted the bug-#577_PopulationSessions branch March 28, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handling population SESSIONS; incorrect volumetric stats output

3 participants