Conversation
jan-petr
left a comment
There was a problem hiding this comment.
- The bugs are correctly fixed. Very good.
- The code checking for token and bracket numbers goes beyond what is the definition and will invalid also cases that are not incorrect - see further comments.
- The issue with cbf scan is not dealt with correctly. The correct solution is not to throw out volumes set as "dummies" but to recognize that when we have both control/label/m0scan etc and cbf, then the CBF should be thrown out. At least for GE, I would do that. The thing is that GE nicely works out of DICOM without extra settings and I would be happier if this is done automatically and automatically deciding to throw CBF out.
1b6389f to
8c84b45
Compare
jan-petr
left a comment
There was a problem hiding this comment.
The last issue about token numbers is still not addressed.
|
See my last edit, I have now added the clarification, that Unless you can come up with an example where you want to have |
Signed-off-by: Henk Mutsaerts <[email protected]>
e08bd69 to
fd3e5b7
Compare
Linked issue
Closes #1294