Closes #1326 replaced checking of file system with checking of flavors.json#1328
Merged
maartenhammer merged 2 commits intodevelopfrom Mar 3, 2023
Merged
Closes #1326 replaced checking of file system with checking of flavors.json#1328maartenhammer merged 2 commits intodevelopfrom
maartenhammer merged 2 commits intodevelopfrom
Conversation
1 task
maartenhammer
force-pushed
the
bug-#1326-Flavor-Crash
branch
from
71f79ca to
437ccff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1326
The added bTesting parameter in flavor.json is now used to check if a flavor needs testing.
How to test
Run Testing/xASL_test_Flavors.m
Comments
I replaced a filesystem search with a check from flavors.json.
Which means if a file is renamed in filesystem, but not in flavors.json it will not run in test_Flavors.m.
This can be fixed by adding the following check:
First a filesystem check xASL_adm_GetFileList(testConfig.pathFlavorDatabase, [], false, [], true);
Then a json read from the flavors.json with associated btesting value.
If both exists and btesting=true, then add it to a to be tested flavor
If flavor exists in either flavor.json or filesystem but not both throw a warning/error pointing the user to check it out, as this means either Flavor.json is incomplete, or the FlavorDatabase is incomplete.