Skip to content

Optimize #1311 matlab json#1312

Merged
jan-petr merged 10 commits intodevelopfrom
optimize-#1311_MatlabJSON
Mar 16, 2023
Merged

Optimize #1311 matlab json#1312
jan-petr merged 10 commits intodevelopfrom
optimize-#1311_MatlabJSON

Conversation

@jan-petr
Copy link
Contributor

@jan-petr jan-petr commented Feb 3, 2023

Linked issue

Closes #1311

@jan-petr jan-petr self-assigned this Feb 3, 2023
@jan-petr jan-petr linked an issue Feb 3, 2023 that may be closed by this pull request
Use Matlab internal json-encode functions instead of SPM routines #1311
Closed
11 tasks
@jan-petr
Copy link
Contributor Author

jan-petr commented Feb 6, 2023 •
edited
Loading

COMPARISON TABLE:]
flavor dataset name message
_______________________________________________ ____________________ __________________________ ___________________________________________________________________________________

 {'Siemens_PCASL_3DGRASE_VB17A_TopUp_2'        }    {'rawdata'         }    {'Missing file'          }    {'/sub-SUB002/fmap/sub-SUB002_dir-pa_m0scan.json'                                 }
{'Siemens_PCASL_3DGRASE_VB17A_TopUp_2'        }    {'rawdata'         }    {'Missing file'          }    {'/sub-SUB002/fmap/sub-SUB002_dir-pa_m0scan.nii.gz'                               }
{'Siemens_PCASL_3DGRASE_VB17A_TopUp_2'        }    {'rawdata'         }    {'Missing file'          }    {'/sub-SUB002/perf/sub-SUB002_asl.json'                                           }
{'Siemens_PCASL_3DGRASE_VB17A_TopUp_2'        }    {'rawdata'         }    {'Missing file'          }    {'/sub-SUB002/perf/sub-SUB002_asl.nii.gz'                                         }
{'Siemens_PCASL_3DGRASE_VB17A_TopUp_2'        }    {'rawdata'         }    {'Missing file'          }    {'/sub-SUB002/perf/sub-SUB002_aslcontext.tsv'                                     }
{'Siemens_PCASL_3DGRASE_VB17A_TopUp_2'        }    {'rawdata'         }    {'Missing file'          }    {'/sub-SUB002/perf/sub-SUB002_dir-ap_m0scan.json'                                 }
{'Siemens_PCASL_3DGRASE_VB17A_TopUp_2'        }    {'rawdata'         }    {'Missing file'          }    {'/sub-SUB002/perf/sub-SUB002_dir-ap_m0scan.nii.gz'                               }

HenkMutsaerts
HenkMutsaerts approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@HenkMutsaerts HenkMutsaerts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a large change, and nice that you wrote unit tests as well. I would really test this one thoroughly before merging with develop.

@jan-petr
Copy link
Contributor Author

jan-petr commented Feb 7, 2023

Quite a large change, and nice that you wrote unit tests as well. I would really test this one thoroughly before merging with develop.

Of course :) And I found quite some bugs. But all is fixed now. Our complete set of tests runs fine, except for one dataset in Flavors - this still has to be fixed.

@jan-petr jan-petr force-pushed the optimize-#1311_MatlabJSON branch from 8baf2a3 to 4ed1866 Compare March 16, 2023 20:46
@jan-petr jan-petr merged commit 4ed1866 into develop Mar 16, 2023
@jan-petr jan-petr deleted the optimize-#1311_MatlabJSON branch March 16, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HenkMutsaerts HenkMutsaerts HenkMutsaerts approved these changes

Assignees

@jan-petr jan-petr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use Matlab internal json-encode functions instead of SPM routines

2 participants

@jan-petr @HenkMutsaerts