Skip to content

Closes #1178 xASL_init_Iteration: fix diaryFile for LongReg#1305

Merged
jan-petr merged 4 commits intodevelopfrom
bug-#1178_diaryFile_LongReg
Apr 4, 2023
Merged

Closes #1178 xASL_init_Iteration: fix diaryFile for LongReg#1305
jan-petr merged 4 commits intodevelopfrom
bug-#1178_diaryFile_LongReg

Conversation

@HenkMutsaerts
Copy link
Member

@HenkMutsaerts HenkMutsaerts commented Jan 31, 2023 •
edited by jan-petr
Loading

Linked issue

Closes #1178

@HenkMutsaerts HenkMutsaerts linked an issue Jan 31, 2023 that may be closed by this pull request
Symbol not defined: SESSION -- when running Longitudinal Registration #1178
Closed
4 tasks
jan-petr
jan-petr requested changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit looks good. But please check and close all tasks from the main issue first.

@jan-petr jan-petr self-assigned this Feb 2, 2023
@HenkMutsaerts
Copy link
Member Author

HenkMutsaerts commented Feb 3, 2023

Done, see issue. Also addressed the request by Toshihiko, though he should test it (we don't have a TestDataSet for DARTEL or LongReg); btw: should he run LongReg or DARTEL?

@jan-petr
Copy link
Contributor

jan-petr commented Feb 4, 2023 •
edited by HenkMutsaerts
Loading

Done, see issue. Also addressed the request by Toshihiko, though he should test it (we don't have a TestDataSet for DARTEL or LongReg); btw: should he run LongReg or DARTEL?

You mean a request that doesn't have an issue yet? Good. Thanks. BTW: Is issue #1103 also fixed by this?

HENK: no, read my response in the issue itself.

jan-petr
jan-petr requested changes Feb 4, 2023
View reviewed changes
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor question only.

jan-petr
jan-petr requested changes Mar 18, 2023
View reviewed changes
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have clarified my question now. Maybe it is all OK - I'm just asking if this was done on purpose.

@jan-petr jan-petr self-requested a review March 23, 2023 18:43
jan-petr
jan-petr requested changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See last questions in code. It's just to double-check, not necessarily wrong...

jan-petr
jan-petr approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@jan-petr jan-petr force-pushed the bug-#1178_diaryFile_LongReg branch from 4b6265e to ded5cb2 Compare April 4, 2023 06:59
@jan-petr jan-petr merged commit ded5cb2 into develop Apr 4, 2023
@jan-petr jan-petr deleted the bug-#1178_diaryFile_LongReg branch April 4, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-petr jan-petr jan-petr approved these changes

@MauricePasternak MauricePasternak Awaiting requested review from MauricePasternak

Assignees

@jan-petr jan-petr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Symbol not defined: SESSION -- when running Longitudinal Registration

2 participants

@HenkMutsaerts @jan-petr