Conversation
Member
Author
|
@jan-petr Please go through these changes when looking at the test example that I added to the FlavorDatabase, then you understand some of my suggestions; otherwise, we should go through these together. |
Contributor
|
I've resolved some comments and checked new updates - only 3 issues left to be addressed. |
Member
Author
|
@jan-petr I have resolved the last issues, if you can merge the NIfTI example in the Flavor Database (in branch feature 1300), then this can be closed. |
A NIfTI without JSON for anatomical scans is ideal and not BIDS-compatible, but we can still process, so it should not crash the pipeline (which would only copy 1 anatomical scan and skip any other anatomical scans)
jan-petr
force-pushed
the
feature-#1300_NIfTI_import
branch
from
71dcb75 to
0191689
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #1300
How to test
See #1300 and please also check and merge flavor #1300 in the FlavorDatabase.
Comments
Optional: add helpful comments for the reviewers here