#1295 Write WMH count to the subject dir#1296
Merged
Conversation
HenkMutsaerts
requested review from
HenkMutsaerts
and removed request for
MDijsselhof
HenkMutsaerts
requested changes
Jan 31, 2023
Member
HenkMutsaerts
left a comment
HenkMutsaerts
left a comment
There was a problem hiding this comment.
How much time did you spend on this, would it be worth checking with me first?
Contributor
Author
Not much. But read again - this has to be fixed. The previous implementation was causing bugs in parallel mode... |
HenkMutsaerts
approved these changes
Jan 31, 2023
Member
HenkMutsaerts
left a comment
HenkMutsaerts
left a comment
There was a problem hiding this comment.
See my comments, this should fix my issues
HenkMutsaerts
requested changes
Feb 3, 2023
Member
HenkMutsaerts
left a comment
HenkMutsaerts
left a comment
There was a problem hiding this comment.
Minor question but mostly fine
HenkMutsaerts
approved these changes
Feb 3, 2023
Also improved the header so it is clear what this parameters does, both converting a CSV to TSV & overwriting any pre-existing TSV
jan-petr
force-pushed
the
bug-#1295_WMHCount
branch
from
6637625 to
840abb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #1295