#1218 xASL_bids_MergeNifti Fix TE ordering#1219
Merged
Conversation
5 tasks
HenkMutsaerts
requested changes
Oct 31, 2022
Member
HenkMutsaerts
left a comment
HenkMutsaerts
left a comment
There was a problem hiding this comment.
Very nice, I would just keep generalizability the back of your mind, otherwise this quick and dirty sequence-specific solution needs another sequence-specific solution for another specific sequence etc etc. But that's maybe for later.
HenkMutsaerts
requested changes
Nov 10, 2022
Member
HenkMutsaerts
left a comment
HenkMutsaerts
left a comment
There was a problem hiding this comment.
Final 2 minor remarks, just for keeping generalizability and specific cases separate.
HenkMutsaerts
approved these changes
Nov 22, 2022
jan-petr
force-pushed
the
bug-#1218_hadamardOrdering
branch
from
c7d89be to
5c2cd27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #1218