Closes #1197 xASL_module_Population: add x.S.DataTypes#1207
Merged
Closes #1197 xASL_module_Population: add x.S.DataTypes#1207
Conversation
jan-petr
requested changes
Oct 14, 2022
Contributor
jan-petr
left a comment
jan-petr
left a comment
There was a problem hiding this comment.
Two minor things.
Also, we should add this new dataPar parameter to the Documentation.
Can you please draft something and I'll put it here?
https://exploreasl.github.io/Documentation/1.10.0beta/ProcessingParameters/
2 tasks
Member
Author
|
Can you re-review? For the dataPar template online: x.S.[...] DataTypes = Vector of cells specifying which images to take data from, in the ROI analysis. E.g., {'Tex’, 'ATT' 'SD' 'M0' ‘rc1T1’} OPTIONAL, DEFAULT = {‘qCBF’} |
jan-petr
requested review from
jan-petr
and removed request for
BeatrizPadrela
jan-petr
force-pushed
the
feature-#1197_DataTypes
branch
from
f247114 to
824fc2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #1197
How to test
dataPar.jsonand run the population module @BeatrizPadrela to test if this new feature worksqCBFas it originally did)Comments
@jan-petr Should we add this new parameter to the
dataParTemplate.md(this is now removed and only online right?)