Conversation
HenkMutsaerts
left a comment
There was a problem hiding this comment.
See comments. Also, where did my edits go? (they were about being flexible with the NIfTI naming, using regular expressions, when doing NII2BIDS)
|
Last thing - regarding adding similar warnings as you did in the alternative commit: There is no need to add those because they are already there. You didn't add a new warning, you have simply taken an existing one and moved it to a different location. So that warning is still there in |
That's not what I meant. In the code that Bea and me changed, you want a warning if an incorrect filename was detected (which you said is impossible, but it will still help us). And to improve the warnings there, to be a bit more explanatory. |
You mean, not a warning that the file was missing, but a warning that a similar filename was detected, but not according to what was expected? |
|
Now the warnings are similar to as they were in your commits. |
HenkMutsaerts
left a comment
There was a problem hiding this comment.
Nice. Minor cosmetics, we should always add a space ' ' after a comma in Matlab (I learned from somebody :) and you put ( ) that are not required in Matlab.
Linked issue
Closes #1167