Skip to content

Closes #1111 disable m0 quantification#1144

Merged
jan-petr merged 20 commits intodevelopfrom
feature-#1111_DisableM0Quantification
Aug 16, 2022
Merged

Closes #1111 disable m0 quantification#1144
jan-petr merged 20 commits intodevelopfrom
feature-#1111_DisableM0Quantification

Conversation

@HenkMutsaerts
Copy link
Member

@HenkMutsaerts HenkMutsaerts commented Aug 7, 2022

Linked issue

Closes #1111

@HenkMutsaerts HenkMutsaerts linked an issue Aug 7, 2022 that may be closed by this pull request
8 tasks
@jan-petr jan-petr assigned jan-petr and unassigned maartenhammer Aug 11, 2022
@jan-petr jan-petr removed the request for review from maartenhammer August 11, 2022 20:14
@jan-petr
Copy link
Contributor

There were minor errors in xASL_adm_LoadParms.m and in xASL_bids_BIDSifyASLJSON.m.

xASL_bids_parseM0.m was fine, but I wanted to clean the code a bit.

@jan-petr
Copy link
Contributor

I reverted the DataParTemplate changes, because this files has been outdated and removed in another issue. We have this description now uniquely in the Documentation to have a single point of information.

I've taken your changes and updated the documentation accordingly.

@jan-petr
Copy link
Contributor

Just cleaning xASL_module_ASL and then changes in single-PLD quantification have to be applied to the multi-PLD one as well. We already have an issue to merge these two, but in the future.

@jan-petr
Copy link
Contributor

The options with missing Structural modules were messed up in the commit - I had to revert those.

Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@jan-petr jan-petr force-pushed the feature-#1111_DisableM0Quantification branch from e2e9013 to 8834738 Compare August 16, 2022 18:19
@jan-petr jan-petr merged commit 8834738 into develop Aug 16, 2022
@jan-petr jan-petr deleted the feature-#1111_DisableM0Quantification branch August 16, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to disable M0 processing

3 participants