Closes #1142 xASL_init_checkDataSetRoot#1143
Merged
Conversation
1 task
jan-petr
approved these changes
Aug 15, 2022
Contributor
jan-petr
left a comment
jan-petr
left a comment
There was a problem hiding this comment.
I fixed minor stuff and agree to merge.
Member
Author
|
Nice, note that it the "the path" (when the path is specified) and "a path" (when it is not specified yet). So ExploreASL requires "a path" (not specified yet), and "the provided path" should be a file (already specified). I avoided printing the path as this leads to very long warnings. But fine as it is now, you can merge with my final changes if you agree. |
jan-petr
force-pushed
the
feature-#1142_xASL_init_checkDataSetRoot
branch
from
1785d00 to
c56ab6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #1142
How to test
Required: if not defined in the linked issue, add a simple test description here
Comments
Optional: add helpful comments for the reviewers here