Closes #1134 xASL_init_DefineIndependentSettings#1135
Merged
Conversation
1 task
jan-petr
requested changes
Aug 15, 2022
Contributor
jan-petr
left a comment
jan-petr
left a comment
There was a problem hiding this comment.
I would consider replacing the unknown version with
"0.0.0 VERSION_unknown" or "0.0.0 VERSION_File_Missing" - so that any function that works with the version number will be able to simply handle this and give a version 0. Otherwise, we'll have to modify all these functions.
jan-petr
force-pushed
the
feature-#1134_VERSIONfile
branch
from
a640fae to
2caaae3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #1134
How to test
Required: if not defined in the linked issue, add a simple test description here
Comments
Optional: add helpful comments for the reviewers here