Release #1015 v1.9.0 by MichaelStritt · Pull Request #1016 · ExploreASL/ExploreASL

MichaelStritt · 2021-12-17T09:18:44Z

Linked issue

Check out the release issue #1015.

…is during init

…lboxes

…ction

…apolate

MichaelStritt · 2021-12-27T16:53:55Z

Unit testing (Windows)

I think there is still only one minor thing we have to update in the ExploreASL_Master unit test...

... the error in xASL_adm_CorrectName is the windows related bug that we've talked about.

So generally I'd say we're fine to release with regard to the unit tests.

====================================== TEST RESULTS ======================================

                        name                           unit           tests        passed
    ____________________________________________    __________    _____________    ______

    'xASL_adm_CatchNumbersFromString'               'function'    [1×3  struct]    true  
    'xASL_adm_CheckFileCount'                       'function'    [1×2  struct]    true  
    'xASL_adm_CompareLists'                         'function'    [1×2  struct]    true  
    'xASL_adm_CorrectName'                          'function'    [1×3  struct]    false 
    'xASL_adm_DeleteFileList'                       'function'    [1×2  struct]    true  
    'xASL_adm_OrderFields'                          'function'    [1×1  struct]    true  
    'xASL_bids_BIDS2Legacy'                         'function'    [1×2  struct]    true  
    'xASL_bids_CheckDatasetDescription'             'function'    [1×2  struct]    true  
    'xASL_bids_CompareStructures'                   'function'    [1×4  struct]    true  
    'xASL_bids_Config'                              'function'    [1×1  struct]    true  
    'xASL_bids_CreateDatasetDescriptionTemplate'    'function'    [1×2  struct]    true  
    'xASL_bids_JsonCheck'                           'function'    [1×3  struct]    true  
    'xASL_bids_VendorFieldCheck'                    'function'    [1×1  struct]    true  
    'xASL_im_CompareNiftis'                         'function'    [1×2  struct]    true  
    'xASL_im_ResampleLinear'                        'function'    [1×5  struct]    true  
    'xASL_io_ExportVTK'                             'function'    [1×5  struct]    true  
    'xASL_io_Nifti2Im'                              'function'    [1×1  struct]    true  
    'xASL_spm_admin'                                'function'    [1×1  struct]    true  
    'xASL_spm_reslice'                              'function'    [1×2  struct]    true  
    'xASL_spm_smooth'                               'function'    [1×1  struct]    true  
    'xASL_stat_PSNR'                                'function'    [1×2  struct]    true  
    'xASL_stat_QuantileNan'                         'function'    [1×1  struct]    true  
    'xASL_stat_StdNan'                              'function'    [1×3  struct]    true  
    'xASL_str2num'                                  'function'    [1×3  struct]    true  
    'xASL_test_GetLogContent'                       'function'    [1×2  struct]    true  
    'xASL_tsvRead'                                  'function'    [1×2  struct]    true  
    'xASL_tsvWrite'                                 'function'    [1×2  struct]    true  
    'xASL_ExploreASL'                               'master'      [1×1  struct]    true  
    'xASL_ExploreASL_Master'                        'master'      [1×11 struct]    false 
    'xASL_module_ASL'                               'module'      [1×1  struct]    true  
    'xASL_module_Population'                        'module'      [1×1  struct]    true  
    'xASL_module_Structural'                        'module'      [1×1  struct]    true  

==========================================================================================

MichaelStritt · 2021-12-27T17:07:46Z

Flavor testing (Windows)

I did a quick test if the new comparison functions work better. I just used this single GE flavor and ran the full testing...

{
   "pathExploreASL": "M:\\SoftwareDevelopment\\MATLAB\\m.stritt\\Server_xASL\\ExploreASL",
   "pathFlavorDatabase": "M:\\SoftwareDevelopment\\MATLAB\\m.stritt\\Server_xASL\\FlavorDatabase",
   "cmdCloneFlavors": "git clone [email protected]:ExploreASL/FlavorDatabase.git",
   "flavorList": ["GE_PCASL_3Dspiral_14.0LX_WIP_1"]
}

... with that we get two empty tables, so exactly what we want ...

COMPARISON TABLE:
LOGGING TABLE:

... I hope I didn't mess up some of the comparisons in between. We should make sure that we don't ignore differences that we want to be able to see. That's it from my side, back to vacation time 😄

jan-petr

OK

MichaelStritt and others added 30 commits November 15, 2021 15:59

#799 xASL_imp_BasicParameterChecks: improve header

b7ac814

#799 xASL_imp_CheckDirectoriesAndPermissions: header update

d56ca55

#799 xASL_imp_CheckImportSettings: update header

2abe7ea

#799 xASL_imp_DetermineSubjectStructure: add x.overview explanation

cd68a31

#799 xASL_imp_DCM2NII: improve comments

8841ba3

#799 xASL_adm_PaddedString: simplify design

75fb1e2

#799 xASL_imp_NII2BIDS_Subject: cosmetics

55fe188

#799 xASL_module_Import: header

083b9ed

#799 xASL_adm_PaddedString: default width

309a9bb

#799 xASL_adm_BreakString: rename and minor revamp

9faec44

#799 Remove x.design and minor optimization

73729f8

#799 Minor design related bugfixes

dc51db9

#799 xASL_im_ResampleLinearFair: refactor and move newline to skip th…

c30b4a7

…is during init

#799 xASL_im_ResampleLinearFair: fix code style

1477956

#799 xASL_..._SortASLVolumes: add warning for empty nifti tables

c927fcb

#799 xASL_imp_FinishImport: fix dataPar.json export

8575e04

#799 xASL_io_dcm2nii: cosmetics and minor improvements

f83fce5

#799 xASL_test_...: set use mni as dummy structural individually

6187473

#799 Add missing dataPar argument, use BreakString consistently

6ef3698

#799 xASL_adm_BreakString: Improve headers

bc7f42f

#799 Add warning for missing x.SUBJECTS

99d4b5d

#799 Use BreakString consistently

35745b9

#909 xASL_im_M0ErodeSmoothExtrapolate: lower threshold fixed

c6920be

#892 ExploreASL_Initialize: rm paths before addpath

ec31459

#892 ExploreASL_Initialize: reduce verbosity, keep matlab related too…

6b68bfa

…lboxes

#892 ExploreASL_Initialize: version related toolboxes

31d2bfe

#892 ExploreASL_Initialize: add filesep

f451816

#907 xASL_fsl_SetFSLdir: add WSL2 compatibility

19c1ab5

#911 xASL_module_ASL: Revamp initialization

9ea9338

#911 xASL_module_ASL: minor design fix for the docu crawler

fdd51c3

This comment has been minimized.

Sign in to view

jan-petr and others added 13 commits December 22, 2021 11:42

#1015 Fix UT of ExploreASL_Master

514c6f8

#1015 Revert M0 threshold to 1.8.0 value

c95bc05

#1015 xASL_test_...: compare derivatives with reference (#1034)

d42cf7c

#1023 xASL_qc_TestExploreASL: update log output folder

c4c6fa0

#1023 ExploreASL_Initialize: fix genpath bids-matlab

123cc99

#1015 Minor header fix

0857dd2

#1033 xASL_im_M0ErodeSmoothExtrapolate: allow running as separate fun…

56e69bb

…ction

#1033 xASL_im_FillNaNs: remove unused x

5aeb569

#1033 xASL_wrp_ProcessM0: update inputs xASL_im_M0ErodeSmoothExtrapolate

73cff82

#1033 xASL_im_FillNaNs: update input parameters

01e0b10

#1033 brainCentralityMap

47a4f8a

#1033 xASL_im_M0ErodeSmoothingExtrapolate: revise thresholding

c3e0c67

#1033 xASL_wrp_ProcessM0: Updated inputs xASL_im_M0ErodeSmoothingExtr…

fd52810

…apolate

jan-petr and others added 9 commits December 27, 2021 22:38

#1033 Fixed headers

911652f

#1033 Fix order of required input variables

3f210dd

#1033 xASL_im_M0ErodeSmoothExtrapolate: Force good quality option

d0f72d4

#1033 xASL_im_M0ErodeSmoothExtrapolate: Make pvGM & pvWM required

104e1b5

#1033 xASL_im_M0ErodeSmoothExtrapolate: improve feedback to the screen

e93bb74

#1033 xASL_wrp_ProcessM0: adapt input xASL_im_M0ErodeSmoothExtrapolate

b47035f

#1033 xASL_im_M0ErodeSmoothExtrapolate: add comments

a52abb0

#1033 xASL_im_M0ErodeSmoothExtrapolate: take FoV into account

dd8d63a

#1033 Update CHANGES.md

15f10db

jan-petr approved these changes Dec 29, 2021

View reviewed changes

jan-petr self-assigned this Dec 29, 2021

HenkMutsaerts approved these changes Dec 29, 2021

View reviewed changes

jan-petr merged commit 15f10db into main Dec 29, 2021

jan-petr deleted the release-#1015_v1.9.0 branch December 29, 2021 15:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release #1015 v1.9.0#1016

Release #1015 v1.9.0#1016
jan-petr merged 398 commits intomainfrom
release-#1015_v1.9.0

MichaelStritt commented Dec 17, 2021

Uh oh!

This comment has been minimized.

MichaelStritt commented Dec 27, 2021 •

edited

Loading

Uh oh!

MichaelStritt commented Dec 27, 2021

Uh oh!

jan-petr left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

MichaelStritt commented Dec 17, 2021

Linked issue

Uh oh!

This comment has been minimized.

MichaelStritt commented Dec 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit testing (Windows)

Uh oh!

MichaelStritt commented Dec 27, 2021

Flavor testing (Windows)

Uh oh!

jan-petr left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MichaelStritt commented Dec 27, 2021 •

edited

Loading