-
Notifications
You must be signed in to change notification settings - Fork 13
Closed
Labels
aspireASPIRE project related issuesASPIRE project related issuesbugSomething isn't workingSomething isn't working
Milestone
Description
Description
PDF report has been revamped. But we have now also changed the way the QC is created. After merging #1225 ,
Basically, we don't now have info inside x.output.ASL, but there are subfields based on sessions.
Same for structural.
And we have to be careful that all from x,output.ASL is now deleted what is not inserted in these subfields - so that could apply to sub fields inserted by the PDF report.
Basically, we are synchronizing edits made in #1225 and #1514. Both were already merged. #1551 is also already merged.
Tasks
- Change the way x.output and x.output_im is used in xASL_qc_ParsePdfConfig.m
- Manage default number of floating points (digits after floating point)
- Change the way x.output and x.output_im is used in xASL_qc_ParsePdfConfig.m - line 90, we create the PDF - but do we create it for each ASL session? Or once per subject? Each has its disadvantages as we either have the structural module multiple times or we need to detect the last ASL session and call it for all previous ASL sessions. But maybe a re-creation for all ASL sessions will work with some extra overhead.
- xASL_qc_ParsePdfConfig.m/xASL_sub_createModuleContent - For ASL module, we use an extra subfield session. x.Output.ASL.ASL_1 and x.Output_im.ASL.ASL_1.
- xASL_qc_ParsePdfConfig.m - take the current ASL session into account. Add the session name to the PDF filename.
- Update Docs to explain the changes
HENK: 31-12-2024
- bugfix: for 1:size() -> for 1:length()
- convert pageIdentifier to identifier in /WorkInProgress/QualityControl/PDFGenerator.md
- recreate the config file for each subject, because each subject can have different modules
- move the config file location to the subject rather than derivatives root folder
- do the crawling for creating the config file not module-specific, but based on having number of sessions (dwi & fmri can also have multiple sessions, but these modules are not really used)
How to test
- Unit Test
- Henk: tested with 1. Structural + ASL_1 modules (TestDataSet) & 2. ASL_1 + ASL_2 FlavorDatabase/Siemens_PCASL_2DEPI_E11_1)
- Henk: Checked the PDF
Release notes
Generate PDF reports also for multiple ASL runs
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
aspireASPIRE project related issuesASPIRE project related issuesbugSomething isn't workingSomething isn't working