Skip to content

Token order error in flavors import #1388

@jan-petr

Description

@jan-petr

Description

An error crashing several flavors probably related to merging some NII files.

The issues was the number of tokens in token order having to match the number of brackets in folderHierarchy. In regexp, ( ) is not reserved for tokens only and is also used for grouping. Therefore the number of tokens in tokenOrder must by equal or smaller than number of brackets, but not necessarily equal.

HENK: it should in our use be reserved for tokens only, otherwise it becomes tricky to interpret which brackets are tokens, and which brackets are used for grouping.

Either we switch the type of brackets, or we use the grouping bracket in the token definition, not in folderHierarchy. Let's discuss. But please provide the examples here that crash so I can check as well.

-> ALSO: we need to copy (can be empty) folders from the clinical scan sessions that we are not interested in, to ensure also that our sourceStructure.json works in those cases.

Tasks

  • Fix bugs in previous commits
  • Add missing tags to the SPM version of DICOM read
  • Allow unused tokens, but print a warning
  • Allow token reusing, but print a warning
  • Allow missing tokenSessionAlias in sourcestructure.json

Release notes

Allow unused and reused tokens in sourcestructure.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions