Skip to content

<SUBJECTNAME> vs <SUBJECTNAME>_1 #1103

@HenkMutsaerts

Description

@HenkMutsaerts

Description

When /rawdata/<SUBJECTNAME> /derivatives/ExploreASL/<SUBJECTNAME> both exist, xASL_module_BIDS2Legacy will recreate /derivatives/ExploreASL/<SUBJECTNAME>_1 (failing to recognize that this is the same as the one without _1).

However, if 010_BIDS2LEGACY.status exists for _1, it will behave correctly.

Without 010_BIDS2LEGACY.status, /derivatives/ExploreASL/<SUBJECTNAME_1> will be overwritten.

It is probably nicest to add warnings, see proposed changes below.

Tasks

  • If a folder in /derivatives/ExploreASL/ exists and will be overwritten, issue a warning
  • Recognize that and _1 are the same in /derivatives/ExploreASL (per legacy structure) so that this will also be overwritten and issue a warning

How to test

clone /ExploreASL/External/TestDataSet, run ExploreASL('path', 0, 0), rename sub-Sub1_1 to sub-Sub1 and rerun ExploreASL('path', 0, 0)

This will give the following two warnings. Note that the second warning and text will be shown if a folder already existed, without renaming sub-*** to sub-***_1. This only applies to the first visit/session, and only if the lock file 010_BIDS2LEGACY.status doesn't exist for this subject.

image

Release notes

Fix BIDS2Legacy renaming to SUBJECTNAME_1

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions