Skip to content

Legacy import issues #1093

@HenkMutsaerts

Description

@HenkMutsaerts

Description

  • When StudyID is added as parameter to sourceStructure.json, this may point the import to a wrong folder.

  • Settings added to the studyPar.json will be propagated to the /derivatives/ExploreASL/dataPar.json which is wrong

  • If /dataPar.json exists (which should be renamed to settingsPar.json) this should be taken into account for processing settings

  • we need to keep the parameters belonging to the data and the processing settings strictly separated

Tasks

  • when loading sourceStructure.json, and finding studyID, ignore this and give a warning that we ignore it
  • when processing settings are detected in studyPar.json, ignore them and give a warning that we will ignore them
  • when detecting a dataPar.json in import, take this in account and use settings for processing (so move this to '/derivatives/ExploreASL/') and merge field-by-field with the default dataPar.json created by the import
  • When both import and the whole pipeline has run, and one has only removed the lock files for the processing; it correctly detects that dcm2niiX has been performed but thinks that it should reperform nii2BIDS and this will crash as the temp folder doesn't exist. Hence, if a subject already exists in rawdata, it should skip importing this subject (both in the dcm2niiX and in the nii2BIDS phase)
  • Add these things to UT test of ExploreASL/Import

How to test

Optional: insert description about how to test the code changes here

Release notes

Required: summarize the changes for the release notes here

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions