-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Description
Description
-
When
StudyIDis added as parameter tosourceStructure.json, this may point the import to a wrong folder. -
Settings added to the
studyPar.jsonwill be propagated to the/derivatives/ExploreASL/dataPar.jsonwhich is wrong -
If /
dataPar.jsonexists (which should be renamed tosettingsPar.json) this should be taken into account for processing settings -
we need to keep the parameters belonging to the data and the processing settings strictly separated
Tasks
- when loading
sourceStructure.json, and findingstudyID, ignore this and give a warning that we ignore it - when processing settings are detected in
studyPar.json, ignore them and give a warning that we will ignore them - when detecting a
dataPar.jsonin import, take this in account and use settings for processing (so move this to '/derivatives/ExploreASL/') and merge field-by-field with the defaultdataPar.jsoncreated by the import - When both import and the whole pipeline has run, and one has only removed the lock files for the processing; it correctly detects that dcm2niiX has been performed but thinks that it should reperform nii2BIDS and this will crash as the temp folder doesn't exist. Hence, if a subject already exists in rawdata, it should skip importing this subject (both in the dcm2niiX and in the nii2BIDS phase)
- Add these things to UT test of ExploreASL/Import
How to test
Optional: insert description about how to test the code changes here
Release notes
Required: summarize the changes for the release notes here
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working