Skip to content

Update global_benchmark.py#22

Open
EwoutH wants to merge 3 commits intomainfrom
bench-slow
Open

Update global_benchmark.py#22
EwoutH wants to merge 3 commits intomainfrom
bench-slow

Conversation

@EwoutH
Copy link
Copy Markdown
Owner

@EwoutH EwoutH commented Jan 20, 2024

No description provided.

@EwoutH
Copy link
Copy Markdown
Owner Author

EwoutH commented Jan 20, 2024

/rerun-benchmarks

@EwoutH
Copy link
Copy Markdown
Owner Author

EwoutH commented Jan 20, 2024

Other comment

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 20, 2024

Benchmark Comparison:

Model Size Init time [95% CI] Run time [95% CI]
SchellingModel small 🔵 -2.3% [-2.8%, -1.7%] 🔵 -0.4% [-1.0%, +0.2%]
SchellingModel large 🔵 -2.5% [-3.1%, -1.9%] 🟢 -5.6% [-7.1%, -4.0%]
WolfSheep small 🔵 -0.3% [-1.0%, +0.4%] 🔵 +1.1% [+0.9%, +1.2%]
WolfSheep large 🟢 -31.4% [-47.3%, -15.8%] 🔵 +4.1% [+1.1%, +6.9%]
BoidFlockers small 🔵 +0.3% [-0.3%, +1.0%] 🔵 -0.6% [-1.3%, +0.1%]
BoidFlockers large 🔵 +1.7% [+0.9%, +2.4%] 🔵 +0.9% [-0.1%, +1.9%]

EwoutH added 2 commits January 20, 2024 21:31
@EwoutH
Use pull_request_target
78086eb 
Key changes:
- The `on` trigger is changed to `pull_request_target`.
- The `if` condition in `jobs.run-benchmarks` is updated to `github.event_name == 'pull_request_target'`.
- The `Checkout PR branch` step uses the `refs/pull/${{ github.event.pull_request.number }}/merge` ref, which safely checks out the merged state of the PR.
@EwoutH
Update global_benchmark.py
1952585
@EwoutH EwoutH marked this pull request as draft January 20, 2024 20:35
@EwoutH EwoutH marked this pull request as ready for review January 20, 2024 20:35
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 20, 2024

Benchmark Comparison:

Model Size Init time [95% CI] Run time [95% CI]
SchellingModel small 🔴 +44.0% [+43.4%, +44.6%] 🔴 +4.2% [+3.8%, +4.8%]
SchellingModel large 🔴 +4.6% [+3.6%, +5.6%] 🔵 +0.1% [-0.9%, +1.6%]
WolfSheep small 🔴 +42.1% [+41.7%, +42.6%] 🔴 +10.9% [+10.8%, +11.1%]
WolfSheep large 🔴 +99.1% [+62.3%, +125.6%] 🔵 -2.4% [-3.8%, -0.7%]
BoidFlockers small 🔴 +45.8% [+45.2%, +46.4%] 🔵 +0.5% [-0.2%, +1.1%]
BoidFlockers large 🔴 +22.1% [+21.8%, +22.4%] 🔵 +0.0% [-0.6%, +0.5%]

@EwoutH
Copy link
Copy Markdown
Owner Author

EwoutH commented Jan 20, 2024

/rerun-benchmarks

@EwoutH
Copy link
Copy Markdown
Owner Author

EwoutH commented Jan 20, 2024

/rerun-benchmarks

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 20, 2024

Benchmark Comparison:

Model Size Init time [95% CI] Run time [95% CI]
SchellingModel small 🔵 -1.5% [-1.9%, -1.1%] 🔵 +0.6% [+0.1%, +1.1%]
SchellingModel large 🔵 -1.3% [-2.0%, -0.6%] 🔵 +1.2% [+0.4%, +2.5%]
WolfSheep small 🔵 +0.0% [-0.3%, +0.4%] 🔵 +0.5% [+0.4%, +0.6%]
WolfSheep large 🔵 +8.6% [-0.5%, +26.8%] 🔵 +0.6% [-0.1%, +1.1%]
BoidFlockers small 🔵 +0.1% [-0.3%, +0.5%] 🔵 +1.1% [+0.7%, +1.6%]
BoidFlockers large 🔵 -0.2% [-0.6%, +0.3%] 🔵 +0.6% [+0.3%, +0.9%]

@EwoutH EwoutH mentioned this pull request Jan 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EwoutH