fix GLEW library build configuration#31
Merged
TakesxiSximada merged 2 commits intoEvolutionGym:mainfrom Oct 22, 2023
Merged
Conversation
jagdeepsb
approved these changes
Oct 21, 2023
Collaborator
Author
There was a problem hiding this comment.
thank you for review. I was update environment.yml 5366d83
Collaborator
Author
|
This pull request will be merged after the CI passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on the version of cmake, it may not be possible to search for GLEW, which is a submodule. This phenomenon may occur on macOS.
There seems to be a problem with FindGLEW.cmake provided by Cmake. In order to independently search for GLEW at a unique location, I decided to simply add and use FindGLEW.cmake. In my environment, this allows me to explore GLEW for submodules.
Cmake version 3.27.1 (install by homebrew)
this pull request includes #30 commits (for passing ci tests)