fix: respect gene max_files constraint; remove variable shadowing

onthebigtree · claude · onthebigtree · commit 882480123ff5 · 2026-02-20T19:31:15.000+08:00
Two fixes in this commit:

1. Gene max_files constraint silently ignored (solidify.js:265)
   `Math.max(Number(constraints.max_files) || 0, 20)` forced the
   effective limit to at least 20, so any gene with `max_files &lt; 20`
   (e.g. the built-in gene at line 780 uses `max_files: 12`) had its
   constraint silently overridden. Replace with a conditional that only
   falls back to the default of 20 when no constraint is configured:
     Number(constraints.max_files) &gt; 0 ? Number(constraints.max_files) : DEFAULT_MAX_FILES

2. Redundant variable declarations shadowing outer scope
   - solidify.js: `const sourceType` re-declared inside the
     `eligible_to_broadcast` block with identical logic; the outer
     declaration (line 942) is already in scope there.
   - evolve.js: `const selectedBy` re-declared inside the solidify
     `try` block with identical logic; the outer declaration (line 1036)
     is already in scope there.
   Removing the inner declarations eliminates the shadowing and ensures
   any future change to the outer declaration propagates correctly.

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/src/evolve.js b/src/evolve.js
@@ -1137,7 +1137,6 @@ async function run() {
   try {
     const runId = `run_${Date.now()}`;
     const parentEventId = getLastEventId();
-    const selectedBy = memoryAdvice && memoryAdvice.preferredGeneId ? 'memory_graph+selector' : 'selector';
 
     // Baseline snapshot (before any edits).
     let baselineUntracked = [];
diff --git a/src/gep/solidify.js b/src/gep/solidify.js
@@ -262,7 +262,8 @@ function checkConstraints({ gene, blast, blastRadiusEstimate, repoRoot }) {
 
   if (!gene || gene.type !== 'Gene') return { ok: true, violations, warnings, blastSeverity };
   const constraints = gene.constraints || {};
-  const maxFiles = Math.max(Number(constraints.max_files) || 0, 20);
+  const DEFAULT_MAX_FILES = 20;
+  const maxFiles = Number(constraints.max_files) > 0 ? Number(constraints.max_files) : DEFAULT_MAX_FILES;
 
   // --- Blast radius severity classification ---
   blastSeverity = classifyBlastSeverity({ blast, maxFiles });
@@ -1076,7 +1077,6 @@ function solidify({ intent, summary, dryRun = false, rollbackOnFailure = true }
   // Search-First Evolution: auto-publish eligible capsules to the Hub (as Gene+Capsule bundle).
   let publishResult = null;
   if (!dryRun && capsule && capsule.a2a && capsule.a2a.eligible_to_broadcast) {
-    const sourceType = lastRun && lastRun.source_type ? String(lastRun.source_type) : 'generated';
     const autoPublish = String(process.env.EVOLVER_AUTO_PUBLISH || 'true').toLowerCase() !== 'false';
     const visibility = String(process.env.EVOLVER_DEFAULT_VISIBILITY || 'public').toLowerCase();
     const minPublishScore = Number(process.env.EVOLVER_MIN_PUBLISH_SCORE) || 0.78;
